This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Replace in with const scope for src/core/sys/posix/arpa|net|netinet#2698
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jul 26, 2019
JinShil:discourage_in_posix_arpa
Merged
Replace in with const scope for src/core/sys/posix/arpa|net|netinet#2698dlang-bot merged 1 commit intodlang:masterfrom JinShil:discourage_in_posix_arpa
in with const scope for src/core/sys/posix/arpa|net|netinet#2698dlang-bot merged 1 commit intodlang:masterfrom
JinShil:discourage_in_posix_arpa
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2698" |
thewilsonator
approved these changes
Jul 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About This PR
Followup to
#2676
dlang/phobos#7110
#2680
#2684
#2693
#2694
#2695
This one of several PRs I intend to submit, breaking up #2677 into multiple PRs.
This PR only addresses code in src/core/sys/posix/arpa|net|netinet
Background
This PR is in support of dlang/dmd#10179
inas a parameter storage class is defined asscope const. Howeverinhas not yetbeen properly implemented so its current implementation is equivalent to
const. Properlyimplementing
innow will likely break code, so it is recommended to avoid usingin, andexplicitly use
constorscope constinstead, untilinis properly implemented.The use of
inas a parameter storage class is already discouraged in the documentation. See https://dlang.org/spec/function.html#parameters